Add $PDL::indxformat for PDL_Indx #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids loss of significance when 64bit PDL_Indx values are printed.
This allows pdl(indx, '[ 9007199254740992 ]') to work without rounding due to the 52bit double precision mantissa versus the 63bits + sign for PDL_Indx.
wchristian
force-pushed
the
add-pdl-indxformat-support
branch
from
296270d
to
5db7c89
Compare
I can't believe this hasn't been documented already.
|
I discovered that pdl( indx(), ... ) works while I was working through the $PDL::indxformat stuff! Amazing how you can still learn something fundamental after all this time. Put some examples in the POD so others will realize it can be done. Probably one of those "well known to those who know it well things"! After the fixes, this seems to work for me, I would appreciate independent verification: use PDL;
$PDL::use_commas=1;
$dseq2 = sequence(double, 3,5);
$iseq2 = sequence(indx, 3,5);
$strq2 = ($iseq2+9007199254740992)->string;
print "\$strq2 is $strq2\n";
$ssq2 = pdl( indx(), $strq2 );
print "\$ssq2 is $ssq2\n";
$diffi = pdl( indx, ($iseq2+9007199254740992)->string ) - 9007199254740992;
print "\$diffi is $diffi\n";
$diffii = pdl( indx, ($iseq2+9007199254740992)->string ) - indx(9007199254740992);
print "\$diffii is $diffii\n"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids loss of significance when 64bit PDL_Indx
values are printed. Part of the 64bit cleanup and polish
for PDL-2.015 (planned for release by Dec 2015)