implement Coverage.peek_result #3481
Closed
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements `Coverage.peek_result` that was implemented in MRI here: https://bugs.ruby-lang.org/issues/10816
|
We run the MRI tests and will be updating them for 2.3 as we wrap up behavioral changes. In any case, the change is pretty small. |
|
Merged to ruby-2.3 in ced60e8. We'll merge to master for 9.1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
Coverage.peek_resultthat was implemented in MRIhere:
https://bugs.ruby-lang.org/issues/10816
I didn't add any tests because there are test in the MRI suite that cover this. Also, I admit that I haven't run the JRuby tests but it does compile? ¯_(⊙︿⊙)_/¯