send record fixes to peers who send outdated records #1977
Merged
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, nil, err | ||
| // still return a non-nil record to signify that we received | ||
| // a bad record from this peer | ||
| record = new(pb.Record) |
There was a problem hiding this comment.
ooof-- that embeds a weird/non-obvious assumption here. what about returning a special error, and catching it later
There was a problem hiding this comment.
also, an invalid record should not necessarily be the same as an empty record, malicious peers who send invalid stuff should maybe not be talked to, etc. we may want to deal with them specially later (distinct from a valid but empty record)
There was a problem hiding this comment.
yeah, i agree here. Finding a clean way to do this is hard... :/
ghost
added
whyrusleeping
force-pushed
the
dev0.4.0
branch
2 times, most recently
from
68b9745 to
b0a8591
Compare
whyrusleeping
force-pushed
the
fix/record-accounting
branch
from
6fabee3 to
0a649c7
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
added a commit
that referenced
this pull request
Dec 29, 2015
send record fixes to peers who send outdated records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peers who send records with expired validity are currently not sent a 'fixup' record after a peer does a get operation. This makes invalid records just return a blank record so that the later fixup logic can send them a better record.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com