improve nodebuilder code to not depend on NewIPFSNode #1557
+107
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to deprecate the function
NewIPFSNode
in favor of the node builder. this is the beginning of that change.So far, i've left
NewIPFSNode
intact, but i've removed most (not all) callers of it.I'd like some feedback on the direction i'm taking here before going any farther.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com