Skip to content

Commit 6c0c27f

Browse files
committedAug 10, 2015
Fix intlGUIEditBox leak and uninitialized value in Mapper (reported by valgrind)
1 parent 1c408c4 commit 6c0c27f

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed
 

‎src/guiFormSpecMenu.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -1020,6 +1020,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
10201020
if (g_settings->getBool("freetype")) {
10211021
e = (gui::IGUIElement *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
10221022
true, Environment, this, spec.fid, rect);
1023+
e->drop();
10231024
} else {
10241025
#else
10251026
{
@@ -1119,6 +1120,7 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
11191120
if (g_settings->getBool("freetype")) {
11201121
e = (gui::IGUIEditBox *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
11211122
true, Environment, this, spec.fid, rect);
1123+
e->drop();
11221124
} else {
11231125
#else
11241126
{

‎src/minimap.cpp

+7-6
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,13 @@ Mapper::Mapper(IrrlichtDevice *device, Client *client)
224224

225225
// Initialize minimap data
226226
data = new MinimapData;
227-
data->mode = MINIMAP_MODE_OFF;
228-
data->is_radar = false;
229-
data->map_invalidated = true;
230-
data->heightmap_image = NULL;
231-
data->minimap_image = NULL;
232-
data->texture = NULL;
227+
data->mode = MINIMAP_MODE_OFF;
228+
data->is_radar = false;
229+
data->map_invalidated = true;
230+
data->heightmap_image = NULL;
231+
data->minimap_image = NULL;
232+
data->texture = NULL;
233+
data->heightmap_texture = NULL;
233234
data->minimap_shape_round = g_settings->getBool("minimap_shape_round");
234235

235236
// Get round minimap textures

0 commit comments

Comments
 (0)