[Truffle] Updating to most recent version of Truffle API. Compiles, but does no… #3240
+28
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some parsing like in If we don't need the parent frame (parsing a whole file) then we use the context to reference core classes and such. Forcing them to do it without the context might not be very nice (does it mean everything depending on context has to be set up at the first |
pitr-ch
changed the title
…ut does not implement TruffleLanguage.parse yet.
|
@eregon: In general the parsing of source shouldn't require any context at all. It's just about understanding the source syntax, not really resolving symbols, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t implement TruffleLanguage.parse yet.
Here are the syntactic changes needed to update to new version of Truffle API. However the bigger change is the parse method - it is supposed to be context-less - I have no idea how to implement it properly, the parsing seems to require reference to context right now.