Fix Digest bubblebabble incorrect output on empty string #3238
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: bin/jruby -rdigest -e "p Digest.bubblebabble ''" "xx" After: bin/jruby -rdigest -e "p Digest.bubblebabble ''" "xexax"
|
Hi @chrisseaton What do you think about this PR? :) |
chrisseaton
added a commit
that referenced
this pull request
Aug 12, 2015
Fix Digest bubblebabble incorrect output on empty string
|
... kept this open as this could use some more work, currently |
|
Wow that's strange - it's such a simple change and I thought all the tests were passing (apart from the Truffle MRI tests apparently but they are unrelated). |
|
@chrisseaton sorry it does pass, still compatibility is not "ideal" since the require should work ... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys
Before:
After:
MRI:
and http://web.mit.edu/kenta/www/one/bubblebabble/spec/jrtrjwzi/draft-huima-01.txt
Fixes #2956