Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg function #450

Closed
wants to merge 24 commits into from
Closed

Reorg function #450

wants to merge 24 commits into from

Conversation

emanuele45
Copy link
Contributor

/me thinks this should work...

There are also a couple of bug fixes. :P

…to make them more flexible

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…and removed the redundant query in Announce_Controller->action_selectgroup

Signed-off-by: emanuele <emanuele45@gmail.com>
…and used the function in Announce_Controller->action_send to remove a query from the controller

Signed-off-by: emanuele <emanuele45@gmail.com>
@norv
Copy link
Contributor

norv commented May 24, 2013

Cool stuff, thanks Ema! /loves the queries going away from controllers 🌴

Signed-off-by: emanuele <emanuele45@gmail.com>
…ble, used getEventProperties in Calendar_Controller instead of the query

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…f only the ids + created the function allBoardModerators to get the moderators of all the boards

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

Cool stuff, thanks Ema! /loves the queries going away from controllers 🌴

/me is happy to break stuff!! 👼

@norv
Copy link
Contributor

norv commented May 25, 2013

Except for the funny function (the tricky one, which is asking for boo-boos), do we have many other cases of function which returns an array with a format in one case, and an array with a different format in another case?
It seems to me rather a tricky idea... not necessarily something to keep doing... Even to us it isn't obvious (three fixes!), do we really expect addon/mod makers to use such a function normally? It's the return value, and IMHO it'd better not be in different formats...

We do return more or less data, yes. But by adding to an array (I think?) more fields. Not by changing the format of the array... Unless... do we? 🐰

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

Changed membergroupsById to return only an array of groups, though some parts don't look so nice to see/read. 😒
I'll rework some later.

Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Copy link
Contributor

norv commented May 27, 2013

This has very cool reworkings! I'm tempted to merge this one, although I don't feel we checked everything... But I'm sure them devs don't introduce bugz, so hey.
... Ohwait.

Signed-off-by: Norv <a.w.norv@gmail.com>
@emanuele45
Copy link
Contributor Author

Knowing how I wrote it (using vim (first time I used it) without many of the features I'm used to use when I write code using other editors and without any test at all), I wouldn't trust that last commit so much.... lol

@norv
Copy link
Contributor

norv commented May 27, 2013

emanuele45#7 😈

@norv
Copy link
Contributor

norv commented May 27, 2013

using vim (first time I used it) without many of the features I'm used to use when I write code using other editors

https://googledrive.com/host/0B6LMD0u8OhYYZEotN2QyR1hwR1k/editors-101.html 😆

@emanuele45
Copy link
Contributor Author

lol

It's not that bad...

@norv
Copy link
Contributor

norv commented May 27, 2013

Why not go all the way? :P Ed FTW

@emanuele45
Copy link
Contributor Author

That's tempting! :D
nano has that annoying bar at the bottom with all the commands...

Conflicts:
	sources/subs/Messages.subs.php
Signed-off-by: emanuele <emanuele45@gmail.com>
…w function

Signed-off-by: emanuele <emanuele45@gmail.com>
@norv norv mentioned this pull request May 30, 2013
@norv norv closed this May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants