New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg function #450
Reorg function #450
Conversation
…to make them more flexible Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…and removed the redundant query in Announce_Controller->action_selectgroup Signed-off-by: emanuele <emanuele45@gmail.com>
…and used the function in Announce_Controller->action_send to remove a query from the controller Signed-off-by: emanuele <emanuele45@gmail.com>
Cool stuff, thanks Ema! /loves the queries going away from controllers 🌴 |
Signed-off-by: emanuele <emanuele45@gmail.com>
…ble, used getEventProperties in Calendar_Controller instead of the query Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…f only the ids + created the function allBoardModerators to get the moderators of all the boards Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
/me is happy to break stuff!! 👼 |
Except for the funny function (the tricky one, which is asking for boo-boos), do we have many other cases of function which returns an array with a format in one case, and an array with a different format in another case? We do return more or less data, yes. But by adding to an array (I think?) more fields. Not by changing the format of the array... Unless... do we? 🐰 |
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Changed membergroupsById to return only an array of groups, though some parts don't look so nice to see/read. 😒 |
Signed-off-by: Norv <a.w.norv@gmail.com>
This has very cool reworkings! I'm tempted to merge this one, although I don't feel we checked everything... But I'm sure them devs don't introduce bugz, so hey. |
Signed-off-by: Norv <a.w.norv@gmail.com>
Knowing how I wrote it (using vim (first time I used it) without many of the features I'm used to use when I write code using other editors and without any test at all), I wouldn't trust that last commit so much.... lol |
https://googledrive.com/host/0B6LMD0u8OhYYZEotN2QyR1hwR1k/editors-101.html 😆 |
lol It's not that bad... |
Why not go all the way? :P Ed FTW |
That's tempting! :D |
Missed separator.
Conflicts: sources/subs/Messages.subs.php
Signed-off-by: emanuele <emanuele45@gmail.com>
…w function Signed-off-by: emanuele <emanuele45@gmail.com>
/me thinks this should work...
There are also a couple of bug fixes. :P