Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container CI #133

Merged
merged 1 commit into from Aug 18, 2015
Merged

Use container CI #133

merged 1 commit into from Aug 18, 2015

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented Aug 9, 2015

No description provided.

@mohawk2 mohawk2 force-pushed the containerci branch 2 times, most recently from 9cf3b50 to 953cb78 Compare August 9, 2015 16:38
@zmughal
Copy link
Member

zmughal commented Aug 9, 2015

Looking good! And it seems to run each build about 25% faster individually.

So pgplot5 needs to be added to the whitelist at https://github.com/travis-ci/apt-package-whitelist?

@mohawk2
Copy link
Member Author

mohawk2 commented Aug 9, 2015

Yes it does. In the meantime, I'm going to have it built and installed per the migration instructions.

@zmughal
Copy link
Member

zmughal commented Aug 9, 2015

OK, made a request for pgplot5 at travis-ci/apt-package-safelist#759. Do we want the others?

@mohawk2
Copy link
Member Author

mohawk2 commented Aug 9, 2015

@zmughal I'd say yes we do.

@zmughal
Copy link
Member

zmughal commented Aug 9, 2015

OK, I linked back from the rest of the deps here:

@mohawk2
Copy link
Member Author

mohawk2 commented Aug 9, 2015

Great!

@mohawk2 mohawk2 force-pushed the containerci branch 15 times, most recently from 048ddab to 6fee91d Compare August 9, 2015 19:30
@zmughal
Copy link
Member

zmughal commented Aug 9, 2015

Wow, that was quite a bit of work on pgplot5! It's looking good.

I totally agree that we should drop testing Perl v5.12 - v5.18. Those aren't that useful at this point.

Merge: Aye

@mohawk2 mohawk2 force-pushed the containerci branch 2 times, most recently from 7489420 to c15a413 Compare August 9, 2015 21:16
@mohawk2 mohawk2 force-pushed the containerci branch 4 times, most recently from 81f48ff to 2f97f5f Compare August 9, 2015 22:27
@zmughal
Copy link
Member

zmughal commented Aug 13, 2015

This will need rebasing now that the cherry-pick in #136 is on the master branch.

@mohawk2
Copy link
Member Author

mohawk2 commented Aug 13, 2015

Rebased.

@zmughal
Copy link
Member

zmughal commented Aug 17, 2015

@mohawk2, the whitelists for Travis-CI that we requested just went through, so shouldn't be too much work to get this working now!

@zmughal
Copy link
Member

zmughal commented Aug 18, 2015

CI happiness all around! Looks good. Merge away!

Merge: Aye

@zmughal zmughal added this to the PDL v2.013_01 milestone Aug 18, 2015
@mohawk2 mohawk2 merged commit 934f852 into master Aug 18, 2015
@mohawk2 mohawk2 deleted the containerci branch August 18, 2015 00:39
@coveralls
Copy link

Coverage Status

Coverage decreased (-18.0%) to 44.462% when pulling 934f852 on containerci into 32ca97e on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants