New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to solaris build problem re quiet_nan #135
Conversation
Looks good to me, so if it works on Solaris, merge away! (and release) |
With this change I get:
|
I'll continue to look into it. |
I made a change to how the function signature is defined here. With that change everything continues compiling until:
There need to be input files to |
Try a completely clean build. See if that makes a difference... On Mon, Aug 10, 2015 at 2:07 PM, Zaki Mughal [sivoais] <
|
This is from a clean build. I use If I type |
Running
|
So there are two possibilities: I either change the toplevel pdl: pdl.c
- $(CC) $< -o $@
+ $(CC) $^ -o $@ or run GNU make: Both solutions allow the build to complete and tests all pass. |
I vote for changing the --Chris On Mon, Aug 10, 2015 at 3:01 PM, Zaki Mughal [sivoais] <
|
According to POSIX make:
which means that in this case a POSIX-compliant |
OK, I agree with that @devel-chm. Changing it now. |
Another way is to be explicit by using |
I don't know if you seen the PDL bugs tracker for sf#390 but --Chris On Mon, Aug 10, 2015 at 4:02 PM, Zaki Mughal [sivoais] <
|
This is more portable since some `make`s only expand `$<` in an inference rule rather than an explicit command. See the definition in POSIX <http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html>. This came up with the make(1) in Solaris 11.2.
The quiet_nan() function on Solaris has the signature: double quiet_nan(long n); and this adds a define to set the `long` parameter in the function prototype and function definition. It appears that the logic is already in the code, just that the NANARG determined in mconf.h was not used to declare the local quiet_nan version.
6ccd426
to
6a320a2
Compare
On Solaris 11.2 (uname -a "SunOS solaris 5.11 11.2 i86pc i386 i86pc"):
All tests pass and once Travis-CI is happy, I'll merge this in. |
@devel-chm, the changes have been merged and PDL v2.013 should be ready to go! |
It appears that the logic is already in the code,
just that the NANARG determined in mconf.h was not
used to declare the local quiet_nan version.
Works for me, seems simple. Ok with you?