dont put newlines in refs json output #1571
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| @@ -135,7 +135,7 @@ Note: list all refs recursively with -r. | |||
| return nil, errors.New(obj.Err) | |||
| } | |||
|
|
|||
| return strings.NewReader(obj.Ref), nil | |||
There was a problem hiding this comment.
why no newlines? https://en.wikipedia.org/wiki/Line_Delimited_JSON (i think we do want them)
There was a problem hiding this comment.
there are newlines, just not in the string inside the object. As far as delimiting the json output, that doesnt happen here. We would have to make the change inside the commands/http lib. I can do that in this PR if you like.
There was a problem hiding this comment.
ah. not sure what this means then. what's the output diff?
There was a problem hiding this comment.
basically, instead of putting the newline in the strings we were printing out (as seen in the root comment here: #1477), we print the newlines in the output marshaller. So the output looks exactly the same, and the json objects dont have weird newlines embedded in them.
dont put newlines in refs json output
fixes the newline issue from #1477
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com