[ruby-2.3 Feature #11785] add encoding: optional argument to String.new
#3535
+47
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g.new` Adds kwargs support to String#initialize such that it will accept an optional :encoding argument.
| replace19(arg0); | ||
| @JRubyMethod(name = "initialize", visibility = PRIVATE, optional = 2) | ||
| public IRubyObject initialize19(ThreadContext context, IRubyObject[] args) { | ||
| final String[] validArgs = new String[]{"encoding"}; |
There was a problem hiding this comment.
I'm not quite sure what Java will do here - since it's a final String[], will it be optimized away, or is this going to result in an allocation per invocation? Should this be moved to an array initialized outside of the method?
…ated per invocation. Slightly less typechecking; now behaves similarly to ruby-head when passed invalid types for arg0.
|
picked onto ruby-2.3 with some tunings and maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds kwargs support to String#initialize such that it will accept an optional :encoding argument.