[ruby-2.3] Feature #10730: Implement Array#bsearch_index #3532
+66
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Array#bsearch_index. The binary search is now a private method which returns an int index, and the public #bsearch and #bsearch_index methods utilize it to return an appropriate IRubyObject instance.
| if (!block.isGiven()) { | ||
| return enumeratorize(context.runtime, this, "bsearch"); | ||
| } | ||
|
|
||
| int rVal = bsearch_index_internal(context, block); | ||
| if(rVal == -1) { |
There was a problem hiding this comment.
Not a big deal, but I'm curious why the two if(rVal... statements lack a space between the if and (, but the other if statements do not.
There was a problem hiding this comment.
Heh, because I wasn't paying attention. Will fix it!
kares
added a commit
that referenced
this pull request
Dec 12, 2015
[ruby-2.3] Feature #10730: Implement Array#bsearch_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Array#bsearch_index. The binary search is now a private method which returns an int
index, and the public #bsearch and #bsearch_index methods utilize it to return an appropriate
IRubyObject instance.
This is functionally identical to how the MRI changes were implemented.