Skip to content

Commit

Permalink
Init hasCallProtocolIR to false always
Browse files Browse the repository at this point in the history
* Trying to looking it up in closure is prone to bugs in case
  the closure is being promoted to full build concurrently.

* This fixes the non-deterministic test failures in test:mri
subbuss committed Dec 12, 2015
1 parent 8563414 commit 583ab75
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ public InterpreterContext ensureInstrsReady() {

if (interpreterContext == null) {
interpreterContext = closure.getInterpreterContext();
hasCallProtocolIR = closure.getFlags().contains(IRFlags.HAS_EXPLICIT_CALL_PROTOCOL);
hasCallProtocolIR = false;
}
return interpreterContext;
}
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ public InterpreterContext ensureInstrsReady() {

if (interpreterContext == null) {
interpreterContext = closure.getInterpreterContext();
hasCallProtocolIR = closure.getFlags().contains(IRFlags.HAS_EXPLICIT_CALL_PROTOCOL);
hasCallProtocolIR = false;
}
return interpreterContext;
}

0 comments on commit 583ab75

Please sign in to comment.