Parse chunked responses using ndjson.

dignifiedquire · dignifiedquire · commit ecccc9278fb3 · 2015-12-18T14:47:31.000+01:00
Fixes #135
diff --git a/src/request-api.js b/src/request-api.js
@@ -2,6 +2,7 @@
 
 const Wreck = require('wreck')
 const Qs = require('qs')
+const ndjson = require('ndjson')
 const getFilesStream = require('./get-files-stream')
 
 const isNode = !global.window
@@ -10,14 +11,10 @@ const isNode = !global.window
 
 function parseChunkedJson (res, cb) {
   const parsed = []
-  res.on('data', chunk => {
-    try {
-      parsed.push(JSON.parse(chunk))
-    } catch (err) {
-      // Browser quirks emit more than needed sometimes
-    }
-  })
-  res.on('end', () => cb(null, parsed))
+  res
+    .pipe(ndjson.parse())
+    .on('data', parsed.push.bind(parsed))
+    .on('end', () => cb(null, parsed))
 }
 
 function onRes (buffer, cb) {
diff --git a/test/api/ping.spec.js b/test/api/ping.spec.js
@@ -2,11 +2,6 @@
 
 describe('.ping', () => {
   it('ping another peer', done => {
-    // TODO remove this when https://github.com/ipfs/js-ipfs-api/issues/135 is resolved
-    if (!isNode) {
-      return done()
-    }
-
     apiClients['b'].id((err, id) => {
       expect(err).to.not.exist
 
