Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ff2143c7ec90
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a3a8783b5bb9
Choose a head ref
  • 9 commits
  • 10 files changed
  • 1 contributor

Commits on Dec 17, 2015

  1. Disable full build and JIT when threshold < 0.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    9d4d585 View commit details

  2. Save and restore visibility from binding's frame.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    1a8b8d0 View commit details

  3. Fix order of UpdateBlock and PushBlockBinding.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    5b15e64 View commit details

  4. Mark some methods as used by interp too, for consistency.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    79b0cb8 View commit details

  5. Use same updateBlockState helper from interpreted paths.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    a71479a View commit details

  6. Dead code.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    3200624 View commit details

  7. Only need to initialize the dynscope variable now.

    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    cc74969 View commit details

  8. Change "has protocol" to "can call direct" and fix all paths. 

    IR protocol is not the only requirement for a direct call, and
the updating of both "has ir protocol" flag and the directly-
callable path was racy in both interpreter and JIT. In addition,
full builds and JIT that happen at threshold=0 in sync with
execution were sometimes continuing down the non-direct path using
the direct logic. This resulted in some call protocols running
twice, potentially messing up state for the direct logic.

The new flag is "canCallDirect", indicating that a transition to
the next tier has happened. Paths through normal non-direct logic
that might trigger a tier upgrade now re-check to see if that has
happened, re-branching back to the direct path.
    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    2039454 View commit details

  9. CompiledIRBlockBody should never have non-direct calls. 

    Leaving this logic in place, commented, for the moment.
    @headius
    headius committed Dec 17, 2015
    Copy the full SHA
    a3a8783 View commit details
Loading