Add support for transactions #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of dumping a full stacktrace to the log, the convention within Fedora is to instead append the Exception.getMessage() to the specified error. fcrepo4-labs#31 (comment)
|
This addresses the stacktraces being dumped to the logs, however, does not address @awoods' concern about (potential) redundant calls to prependTransactionId() . It may be my unfamiliarity with the code base, but it appears to me like the subsequent calls to prependTransactionId() for which I reviewed the logic are required for transactions to function correctly. |
There were several instances were prependTransactionId were called on a path parameter to a function which in turn called prependTransactionId. These redundant cases were handled by prependTransactionId, but were unnecessary.
|
Resolved with: 6da86ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request continues on from #31 and looks to address the outstanding issues to allow it to be merged.