Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 0339446cf736
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ea4dc7d44425
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 12, 2014

  1. build: i18n: fix icu toolset dependencies 

    So what I did here is to make the icutools library actually contain the
entire ICU dependencies needed for host-side tools. Sadly, this will
build ICU twice, but avoids conflicts between host and target side.
This all seems like a gyp bug of some sort, but without docs for
toolsets, who’s to say?

I removed the icuio library as a separate target, because it was only
used by the host-side tools.

PR-URL: #8681
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @srl295 @trevnorris
    srl295 authored and trevnorris committed Nov 12, 2014
    Copy the full SHA
    ea4dc7d View commit details
    Browse the repository at this point in the history