for loop etc. #108
for loop etc. #108
Conversation
prakashk
commented
May 10, 2013
prakashk
commented
- Remove the need for semicolons on assignment statements and other places
- for(each) loop (still to do: bind topic variable to each list element when executing the body)
- C-style for loop
superfluous semicolons in some cases. Resolves issue #106.
each list element when loop body is executed.)
|
@prakashk, have I told you lately how awesome you are? |
|
:) Most of the work implementing for/foreach was already there. All I did was add the productions for each of them. BTW, there are a couple of XXX comments in ForeachNode code. I didn't try to understand the issues mentioned and am not sure if they are still applicable. Please review and remove them if no longer needed. On the other hand, I had to spend considerable amount of time fixing the statement terminator issue. I am still not sure if it is 100% there. |
|
First of all, thanks for all your hard work. Some of those XXX notes are mine. I think the second one (about having issues wrapping the object in an AST) was when I introduced the applyScopeInjection. What I wanted to try to do was massage the AST a bit and then evaluate the whole loop as a series of statements. But you have to evaluate the list first, making it impossible to do so. I think the way this is done is good for now. I admit my applyScopeInjection isn't super graceful, but I think its use in ForeachNode is fine for now and we can cross that bridge when the interpreter starts getting cleaned up. |
