Updating LDP membership triples #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| public static final Property INLINED_RESOURCE = | ||
| createProperty(LDP_NAMESPACE + "inlinedResource"); | ||
|
|
||
| public static final Set<Property> ldpProperties = of(PAGE, PAGE_OF, | ||
| FIRST_PAGE, NEXT_PAGE, MEMBERS_INLINED, CONTAINER, | ||
| MEMBERSHIP_SUBJECT, MEMBERSHIP_PREDICATE, MEMBERSHIP_OBJECT, | ||
| MEMBER_SUBJECT, INLINED_RESOURCE); | ||
| MEMBERSHIP_RESOURCE, HAS_MEMBER_RELATION, INLINED_RESOURCE); |
There was a problem hiding this comment.
Should DIRECT_CONTAINER be added to the "ldpProperties" set?
There was a problem hiding this comment.
Container and DirectContainer should probably be Resources instead of Properties -- I'll make a new Set to hold them, which we may want to use when filtering out statements like "<> rdf:type ldp:Container" from updates.
… using RdfLexicon instead of literals
| MEMBER_SUBJECT, INLINED_RESOURCE); | ||
| FIRST_PAGE, NEXT_PAGE, MEMBERS_INLINED, MEMBERSHIP_RESOURCE, | ||
| HAS_MEMBER_RELATION, INLINED_RESOURCE); | ||
| public static final Set<Resource> ldpResources = of(CONTAINER, |
There was a problem hiding this comment.
It does not look like "ldpResources" is actually used anywhere else in the code base. What purpose does it serve here?
There was a problem hiding this comment.
I expect to use it to filter out rdf:type assertions that should not be persisted -- see https://www.pivotaltracker.com/story/show/66168308
|
Resolved with: 8068263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://www.pivotaltracker.com/s/projects/684825/stories/69469312