Code cleanup #17
Closed
Code cleanup #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage header information
|
I am getting merge conflicts when taking this PR and doing "rebase master". |
|
I'll try squashing those commits so you don't need to rebase anything |
|
You still need to rebase on master before a merge is possible. |
…essage header information
…essage header information
…into CodeCleanup
…into CodeCleanup
|
This PR is a bit screwy. I'll send along another (cleaner) one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/82225792
This brings unit tests to ~ 90% coverage and addresses a number of issues identified by sonar.