ResultSet.pm: Permit user defined target classes for low-level use. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentfredric
force-pushed
the
userclass
branch
from
bf82070
to
12d1363
Compare
|
This is an intriguing way of moving past some of the limitations of MetaCPAN::Client. |
|
I suspect this commit introduces a subtle bug if the constructor fails to pass either |
This makes it easier in cases where you want to return a different type of object that may have specific extra features added that may not be useful for MetaCPAN::Client. This avoids the need for downstream users to do re-blessing in strange places to get the same result.
kentfredric
force-pushed
the
userclass
branch
from
12d1363
to
6c18cb1
Compare
|
hi, this is not ready for merging. if relevant - please reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier in cases where you want to return a different type
of object that may have specific extra features added that may not be
useful for MetaCPAN::Client.
This avoids the need for downstream users to do re-blessing in strange
places to get the same result.