Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 193320aa3a12
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 5d3c51d937fe
Choose a head ref
  • 3 commits
  • 11 files changed
  • 2 contributors

Commits on Jan 24, 2013

  1. streams: Support objects other than Buffers 

    We detect for non-string and non-buffer values in onread and
turn the stream into an "objectMode" stream.

If we are in "objectMode" mode then howMuchToRead will
always return 1, state.length will always have 1 appended
to it when there is a new item and fromList always takes
the first value from the list.

This means that for object streams, the n in read(n) is
ignored and read() will always return a single value

Fixed a bug with unpipe where the pipe would break because
the flowing state was not reset to false.

Fixed a bug with sync cb(null, null) in _read which would
forget to end the readable stream
    @Raynos @isaacs
    Raynos authored and isaacs committed Jan 24, 2013
    1
    Copy the full SHA
    444bbd4 View commit details
    Browse the repository at this point in the history

  2. streams2: Handle sync read callbacks nicely

    @isaacs
    isaacs committed Jan 24, 2013
    Copy the full SHA
    782149d View commit details
    Browse the repository at this point in the history

  3. test: Add test for negative stream drain counter

    @isaacs
    isaacs committed Jan 24, 2013
    Copy the full SHA
    5d3c51d View commit details
    Browse the repository at this point in the history