Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: c77312405e04
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 41b75ca9263f
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 20, 2013

  1. cluster: clean up lib/cluster.js 

    Clean up and DRY the cluster source code. Fix a few bugs while we're
here:

* Short-lived handles in long-lived worker processes were never
  reclaimed, resulting in resource leaks.

* Handles in the master process are now closed when the last worker
  that holds a reference to them quits. Previously, they were only
  closed at cluster shutdown.

* The cluster object no longer exposes functions/properties that are
  only valid in the 'other' process, e.g. cluster.fork() is no longer
  exported in worker processes.

So much goodness and still manages to reduce the line count from 590
to 320.
    @bnoordhuis
    bnoordhuis committed Apr 20, 2013
    7
    Copy the full SHA
    41b75ca View commit details
    Browse the repository at this point in the history