Linking to datastream fcr:metadata in HTML UI #573
Conversation
escowles
force-pushed
the
link-to-ds-metadata
branch
from
04b5ece
to
619b3dd
Compare
| @Produces({TEXT_HTML, APPLICATION_XHTML_XML}) | ||
| public Response describeHTML(@HeaderParam("Range") final String rangeValue) throws IOException, ParseException { | ||
| // if no prefer header is set, include child resources so they can be used for conditional link building | ||
| if ( prefer == null ) { |
There was a problem hiding this comment.
I'm not sure it's a good idea to have the HTML response and the RDF responses divergent. If I was debugging an application, pulled a response up in my browser, and saw something, I would expected to see it other places too.
There was a problem hiding this comment.
Are we OK with making EMBED_CONTAINS the default behavior if no Prefer header is provided?
There was a problem hiding this comment.
I would say absolutely not. It has the potential to be a moderate performance hit.
There was a problem hiding this comment.
If the goal is simply to indicate what things are non-binary sources, couldn't we intercept the click event, fire off a HEAD request, and see what we're getting back (and make some decision based on that)?
That would have the added benefit of working for properties that point to binaries too.
There was a problem hiding this comment.
I'm 👍 for including that information everywhere it is relevant, but I don't think it's that easy. Non-binary resources can show up:
- as contained resources of a node
- as LDP member resources
- as objects of reference properties
I spent time last week trying to do just that, and it means redoing a large part of our RDF serialization tools. I don't see how a simple javascript query is that hard to do.
There was a problem hiding this comment.
Is this current PR fundamentally flawed? I would vote for moving it forward as-is.
There was a problem hiding this comment.
@cbeer (aka, captain-JS) can I tempt you with a beer to make the magic happen?
There was a problem hiding this comment.
Yes, I argue it is flawed by either doing the wrong thing, not covering all the possible scenarios, or both.
|
Resolved with: 5e6bb87 |
Fixes https://www.pivotaltracker.com/story/show/80952408