Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9393404
Choose a base ref
...
head repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b55ecbb
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 25, 2012

  1. Use BugData object as function param for several functions 

    Commit 085ab16 introduced an undefined
variable warning, due to removal of a call to bug_get_field function to
retrieve the project_id. This could actually cause the incorrect status
to be retrieved in html_button_bug_reopen() and html_button_bug_close(),
potentially allowing users to close or reopen issues when they are not
entitled to.

Instead of adding the function call back as it was, the code was
modified to use a BugData object instead of a bug id as parameter for
several functions in access_api.php and html_api.php, resulting in
simpler and more efficient code thanks to fewer calls to bug_get() and
bug_get_field().

Fixes #14191, Affects #14156
    @dregad
    dregad committed Apr 25, 2012
    Copy the full SHA
    8407d61 View commit details

  2. Update the bug's Last Update timestamp when editing a bugnote 

    Fixes #7633
    @dregad
    dregad committed Apr 25, 2012
    Copy the full SHA
    b55ecbb View commit details
Loading