Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joda exceptions recently in mri/ruby/test_time.rb #2237

Closed
headius opened this issue Nov 24, 2014 · 1 comment
Closed

Joda exceptions recently in mri/ruby/test_time.rb #2237

headius opened this issue Nov 24, 2014 · 1 comment
Labels
core JRuby 9000
Milestone
Non-Release

Comments

@headius
Copy link
Member

headius commented Nov 24, 2014

Two exceptions I'm seeing for the same test. Unsure why they're different, and unsure why they're happening recently:

Locally for me on Java 7:

TestTime#test_big_minus:
Java::JavaLang::ArithmeticException: Adding time zone offset caused overflow
    org.joda.time.DateTimeZone.convertUTCToLocal(DateTimeZone.java:965)
    org.joda.time.chrono.ZonedChronology$ZonedDateTimeField.get(ZonedChronology.java:422)
    org.joda.time.base.BaseDateTime.<init>(BaseDateTime.java:129)
    org.joda.time.DateTime.<init>(DateTime.java:236)
    org.joda.time.DateTime.withMillis(DateTime.java:598)
    org.jruby.RubyTime.at(RubyTime.java:1053)
    org.jruby.RubyTime$INVOKER$s$at.call(RubyTime$INVOKER$s$at.gen)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:295)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:157)
    org.jruby.ir.interpreter.Interpreter.processCall(Interpreter.java:343)

On CI, all Java versions I believe:

    [exec] Java::OrgJodaTime::IllegalFieldValueException: Value -292275055 for year must be in the range [-292275054,292278993]
     [exec]     org.joda.time.field.FieldUtils.verifyValueBounds(FieldUtils.java:234)
     [exec]     org.joda.time.chrono.BasicYearDateTimeField.set(BasicYearDateTimeField.java:83)
     [exec]     org.joda.time.chrono.ZonedChronology$ZonedDateTimeField.set(ZonedChronology.java:482)
     [exec]     org.joda.time.base.BaseDateTime.<init>(BaseDateTime.java:129)
     [exec]     org.joda.time.DateTime.<init>(DateTime.java:236)
     [exec]     org.joda.time.DateTime.withMillis(DateTime.java:598)
     [exec]     org.jruby.RubyTime.at(RubyTime.java:1053)
     [exec]     org.jruby.RubyTime$INVOKER$s$at.call(RubyTime$INVOKER$s$at.gen)
     [exec]     org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:295)
     [exec]     org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:157)
     [exec]     org.jruby.ir.interpreter.Interpreter.processCall(Interpreter.java:343)

I saw that @cheald made some fixes for similar errors but I'm not sure what the right thing to do is here. Since I'm just trying to get the build green right now, I'm excluding this...but it needs to be fixed for 9k.
@headius headius added the core label Nov 24, 2014
@headius headius added this to the JRuby 9.0.0.0 milestone Nov 24, 2014
headius added a commit that referenced this issue Nov 24, 2014
@headius
Exclude regressed MRI test for #2237.
6414b4b
@mkristian
Copy link
Member

this came from the update of joda to version 2.5 - on jruby-1_7 I took the liberty to fix it like this: bd61d86

not sure why it did not merge that way

@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015
@kares kares added this to the Non-Release milestone Mar 1, 2018
@kares kares closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 9000
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
4 participants
@headius @enebo @mkristian @kares