Fix frozen checks and exceptions #2178
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RI-compliant behavior" This reverts commit 7ff0a1f.
suite and rubyspec suite now.
|
Bleh, so MRI does do this check directly in their bytecode interpreter then. The changes look good, but try to avoid committing commented code or add a comment saying why it's still there. We're trying to build a corpus of small interpreter/compiler specs in spec/compiler/general_spec.rb, so if you feel like adding this case go for it. The format is pretty explanatory, and it will run against both IR interpreter and IR JIT. |
headius
added a commit
that referenced
this pull request
Nov 12, 2014
Fix frozen checks and exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix freeze enforcement and exceptions for immediate values. Passes test suite and rubyspec suite.
I'd love some extra review on this, though - the JRuby code isn't directly analogous to the MRI code, and there is a whole set of checks (FL_ABLE, SPECIAL_CONST_P) that JRuby doesn't do which probably need evaluation.