TRUNK-2779 Clean up patient birthdate error #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nils, I'd kindly ask you to remove and reopen this pull request as you opened it from |
|
Nil, did you do this? |
|
I wasn't available for a while. Sry. I have developed the fix and was now going to move it to a branch, but have now seen that you've already merged my changes. Thank you. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* Migration first draft * Adding some links * Troubleshooting * React-router-dom and Carbon v11 notes * Improved React description * again * Spellcheck * skip link check * Invisible spacing adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a source of an issue:
getRelationshipsMap(@ModelAttribute("patientModel") ShortPatientModel patientModel, WebRequest request)
method didn't have a parameter of type BindingResult which meant that when 'patientModel' parameter was bound BindingException was always thrown which in turn stopped all processing and saveShortPatient() method was never called. This in turn caused exception to be propagated down the stack and resulted in error page being shown. When BindingResult parameter is added, errors are stored within it and no exception is thrown which causes correct error message to be shown when patient's birthdate is incorrect.