Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An IRC reactor implementation #25

Closed
wants to merge 4 commits into from
Closed

Conversation

obazoud
Copy link
Contributor

@obazoud obazoud commented Feb 8, 2013

No description provided.

@mmalecki
Copy link
Contributor

mmalecki commented Feb 9, 2013

Wow, you are awesome. Did you take a look at ircb? It happens to have better error handling than irc module.
Anyway, I'll test this one out today/tomorrow.

@dscape
Copy link
Contributor

dscape commented Feb 9, 2013

👍

@indexzero
Copy link
Member

This is great, but it should have tests :)

@obazoud feel free to mock them.

@indexzero
Copy link
Member

@obazoud Any thoughts on ircb? It's easier for us to make changes to that than irc because it's maintained by @mmalecki

@indexzero
Copy link
Member

Also thinking if we want to add the dependency bloat here. Might be more useful as godot-irc. Not 100% positive about that. @dscape @mmalecki your thoughts?

@mmalecki
Copy link
Contributor

Yeah, godot-irc is nicer IMO.

@obazoud
Copy link
Contributor Author

obazoud commented Feb 13, 2013

Ok I an changing to ircb.
@mmalecki could you release ircb with commit efbc14b

@jokesterfr
Copy link

What's up with this reactor? Is some help required?

@jcrugzz
Copy link
Member

jcrugzz commented Jun 19, 2013

@jokesterfr I believe the consideration was if we should pull this out into a separate module or not and I am more inclined to think that is a good idea. This currently isn't easy in the current form so there will be some things to consider. There will be more info about this soon :).

@obazoud
Copy link
Contributor Author

obazoud commented Jun 20, 2013

@jokesterfr IRC Reator is also available as separate module : https://github.com/godot-plugins/godot-ircb

@indexzero
Copy link
Member

@obazoud Oh great you pulled that out into it's own module. I'm going to close this since it really belongs in a separate module.

Would love to have your work in godot-plugins in the main godot README if you could open a PR.

@indexzero indexzero closed this Jun 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants