TRUNK-3986 #375
Closed
TRUNK-3986 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| errors.rejectValue("conceptNameTag", "error.general"); | ||
| } else { | ||
| ValidationUtils.rejectIfEmptyOrWhitespace(errors, "tag", "error.name"); | ||
| ValidationUtils.rejectIfEmptyOrWhitespace(errors, "description", "error.description"); |
There was a problem hiding this comment.
I think we try not to require description for most metadata
|
|
||
| if (cnt.getTag() != null) { | ||
| for (ConceptNameTag currentTag : Context.getConceptService().getAllConceptNameTags()) { | ||
| if (currentTag != null) { |
There was a problem hiding this comment.
currentTag can't be null, you can use OpenmrsUtil.nullSafeEqualsIgnoreCase otherwise it will fail if the cases are different
|
Closing because author abandoned it. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* (fix) Restore missing side menu on tablet This PR fixes an issue where the side menu was not appearing on tablet. It does so by changing the referenced extension slot from `nav-menu-slot` to `patient-chart-dashboard-slot`. This change allows the navbar component to show a hamburger menu in the top left hand corner of the page. Clicking on this hamburger menu then displays the side menu. * Fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for [TRUNK-3986] Add ConceptNameTagValidator to Core API