Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-2224 Show appropriate notification message when void reason is empty when voiding a patient #835

Closed
wants to merge 1 commit into from

Conversation

aka001
Copy link
Contributor

@aka001 aka001 commented Mar 28, 2014

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Mar 31, 2014

@aka001 i can reopen this after you have addressed the above comment.

@dkayiwa dkayiwa closed this Mar 31, 2014
@aka001
Copy link
Contributor Author

aka001 commented Mar 31, 2014

@dkayiwa Thanks for the review Daniel. I will soon update this pr.

@aka001
Copy link
Contributor Author

aka001 commented Mar 31, 2014

@dkayiwa I referred to LocationFormControllerTest.java and updated the changed in this pr. I haven't done any major changes.
Is the usage of Context class a major issue?
I am unable to find out any other problem in the controller unit test.
Whenever time permits, please specify the problem with the controller unit test file?
Thanks

@dkayiwa
Copy link
Member

dkayiwa commented Mar 31, 2014

@aka001 LocationFormControllerTest is very different from your unit test. Can you look at it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants