Support for Inline::Filters::* plug-ins #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the look of this. While your mind is on the subject, what do you think of the idea of an API for Inline::C addins slightly more generally, so that eg Inline::Filters and Inline::Struct don't need specific support within Inline::C itself? Something like: Possibly the |
|
I think a generic add-in system like that would make sense although I haven't looked closely at much of Inline other than the filtering stuff so I wouldn't feel qualified to design such a system. |
|
@hoytech, please change C<…> to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filters => [ [ Ragel => '-G2' ] ]
is much nicer than
filters => [ sub { require Inline::Filters::Ragel; Inline::Filters::Ragel::ragel('-G2')->(@_) } ]