Allow specs inside subdirectories of {app,lib}/assets/javascripts/spec/ #21
Conversation
| end | ||
|
|
||
| def spec_files_for_glob glob = '**' | ||
| Dir[Rails.root.join("{app,lib}/assets/javascripts/spec/#{glob}{,_spec{.js,}.{rb,opal}}")].map do |path| | ||
| Dir[Rails.root.join("{app,lib}/assets/javascripts/spec/#{glob}.{rb,opal}")].map do |path| |
There was a problem hiding this comment.
I'll probably redo this change as follows:
spec_files_for_glob '**'
# […]
Dir[Rails.root.join("{app,lib}/assets/javascripts/spec/#{glob}{_spec{.js,}.{rb,opal}}")].map do |path|Removing that leading comma should be enough
There was a problem hiding this comment.
That's what I thought at first, however that way it doesn't work anymore when trying to run a single spec file using pattern param.
There was a problem hiding this comment.
can you expand on this? I'd like to turn it into a spec (or two)
There was a problem hiding this comment.
I've added a spec for this in my other commit.
|
Thanks There are three failures on jenkins, a couple seem to be related to the source-maps comment that changed format, the other just doesn't expect the file you added, all should be easy to fix. |
…heck running single spec file
|
Sorry somehow I missed spec directory... Fixed spec related to my changes and added a new spec to check running single file. |
|
👍 almost there: The order of spec files seems to be random (or system dependent) can you split that expectation like this? page.should have_content('subdirectory/other_spec.js')
page.should have_content('example_spec') |
|
Should be fixed, travis doesn't seem to run automatically though? |
|
Thanks, merging (and then fixing the sourmaps specs) |
Allow specs inside subdirectories of {app,lib}/assets/javascripts/spec/
Old code would treat subdirectory itself as a spec file and then fail to find any tests within it. This code fixes that by instead searching for spec files inside it. Not sure if it should search for files ending with _spec or accept all files.
There didn't seem to be any tests for that so I simply added new spec in subdirectory of test app.