Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID command lookups of unconnected nodes #396

Merged
merged 2 commits into from Dec 1, 2014
Merged

Conversation

whyrusleeping
Copy link
Member

A FindNode RPC wont retrieve the peers public key, this change makes the GetID command not print out public keys when they are not there (as opposed to erroring out).

@whyrusleeping whyrusleeping added the status/in-progress In progress label Dec 1, 2014
@jbenet
Copy link
Member

jbenet commented Dec 1, 2014

LGTM RTM 👍

whyrusleeping added a commit that referenced this pull request Dec 1, 2014
Fix ID command lookups of unconnected nodes
@whyrusleeping whyrusleeping merged commit 2ec2c85 into master Dec 1, 2014
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 1, 2014
@whyrusleeping whyrusleeping deleted the idcmd-fix branch December 1, 2014 21:41
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants