-
Notifications
You must be signed in to change notification settings - Fork 728
Comparing changes
Open a pull request
base repository: mantisbt/mantisbt
base: 005243519671
head repository: mantisbt/mantisbt
compare: d38abf9556a3
- 18 commits
- 13 files changed
- 2 contributors
Commits on Dec 14, 2012
-
fix #14559 - Filter for adm_report_config.php
Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Configuration menu - View commit details
-
Copy full SHA for f8a81a3 - Browse repository at this point
Copy the full SHA f8a81a3View commit details -
Issue #14559: improve adm_report_config.php filter
The following changes were made - revised UI to make it more similar to the issues filter - make use of existing constants and language strings - filter defaults to All Users / All Projects / All options which avoids performance issues in installations having a large number of entries in the config table (workaround for issue #13680) - filter form uses post instead of get method - comply to coding guidelines
Configuration menu - View commit details
-
Copy full SHA for 259f95c - Browse repository at this point
Copy the full SHA 259f95cView commit details
Commits on Dec 28, 2012
-
Make it possible to edit config options in adm_config_report.php
Use CONFIG_TYPE_xxx constants instead of magic strings to define the type of config value to process. Added code for FLOAT type which was previously handled through COMPLEX. Improve handling of INT (and FLOAT) by calling constant_replace(), allowing user to specify a defined constant instead of a numeric value. Fixes #7586
Configuration menu - View commit details
-
Copy full SHA for 8890b21 - Browse repository at this point
Copy the full SHA 8890b21View commit details
Commits on Dec 31, 2012
-
- Removed paragraph with incorrect information about need to redefine cookie variables after modifying $g_cookie_prefix. - Revised layout - Updated description for some variables - Reflected these changes in related comments in config_default_inc.php
Configuration menu - View commit details
-
Copy full SHA for 3f75f68 - Browse repository at this point
Copy the full SHA 3f75f68View commit details -
Fix 1st uppercase letter for 'Filters' language string
Affects issue #14559
Configuration menu - View commit details
-
Copy full SHA for 9f72490 - Browse repository at this point
Copy the full SHA 9f72490View commit details -
Respect $g_show_realname setting in config report's filter userlist
The filter's original implementation displayed "Realname (username)" in the user selection list. We now only retrieve the user id from the db, and call user_get_name() to get either the realname or the username as appropriate instead. Issue #14559
Configuration menu - View commit details
-
Copy full SHA for efdd6a7 - Browse repository at this point
Copy the full SHA efdd6a7View commit details -
Manage persistency of config report filter using a cookie
A new cookie 'manage_config_cookie' was added to store the user's filter criteria. Includes documentation update to admin guide. Issue #14559
Configuration menu - View commit details
-
Copy full SHA for 9dbfcd7 - Browse repository at this point
Copy the full SHA 9dbfcd7View commit details -
Rename 'manage_cookie' to 'manage_users_cookie'
After the introduction of the 'manage_config_cookie', the name of the existing cookie ('manage_cookie') which is used to store the filter for the Manage Users page could be misleading, so it has been renamed to 'manage_users_cookie'.
Configuration menu - View commit details
-
Copy full SHA for beea901 - Browse repository at this point
Copy the full SHA beea901View commit details
Commits on Jan 1, 2013
-
Configuration menu - View commit details
-
Copy full SHA for 65696fb - Browse repository at this point
Copy the full SHA 65696fbView commit details
Commits on Jan 2, 2013
-
Config report filter: added handling for invalid values in cookie
In some cases, the cookie could contain values which are no longer applicable as filter criteria, e.g. - a project id which has been deleted - a user id for whom there are no config options - a config id for which there are no config options The code now correctly handles these, by making sure that either the filter criteria is dynamically updated to a valid value (ALL_PROJECTS for projects), or the filter's selection list effectively includes the invalid value (user id, config id), so that the displayed filter reflects the actual data listed in the Database Configuration table. Fixes the bug reported by atrol in issue #14559's bugnote 34648
Configuration menu - View commit details
-
Copy full SHA for b6f03b7 - Browse repository at this point
Copy the full SHA b6f03b7View commit details -
Config report: preset the edit form to the current filter
The 'Username', 'Project Name' and 'Configuration Option' fields in the 'Set Configuration Option' form are now preset to the corresponding value from the filter or defaulting to ALL_USERS, ALL_PROJECTS and blank respectively if the filter is not defined or set to '[any]'. This allows easier definition of related config, e.g. for a given project or user.
Configuration menu - View commit details
-
Copy full SHA for 8b426cf - Browse repository at this point
Copy the full SHA 8b426cfView commit details -
Config report filter: added buttons to clear and reset default filter
This provides the user with a single-click way to - reset the filter to default settings (i.e. ALL_USERS, ALL_PROJECTS, [any] config). - clear the filter to display all configs (i.e. [any] user, [any] project, [any] config) Issue #14559
Configuration menu - View commit details
-
Copy full SHA for d76a210 - Browse repository at this point
Copy the full SHA d76a210View commit details -
Fix performance issue on adm_config_report.php
In systems with large numbers of config items in mantis_config_table, the Configuration Report page can take a very long time to load. This behavior is due to each of the 'Delete' buttons being printed with its own form, each one having a security token. The performance bottleneck is actually the serialize/unserialize calls executed while storing/retrieving the token from the PHP session. To avoid this problem, the print_button() and form_security_field() functions have been modified to accept a security token as an optional parameter. This allows the calling page to generate a single token, which is shared by all buttons. Furthermore, print_button() also allows the security token parameter to be 'OFF', which prevents the function from displaying a security field. This is useful for buttons not resulting in modifications (i.e. not requiring CSRF protection). Fixes #13680
Configuration menu - View commit details
-
Copy full SHA for db0e3d3 - Browse repository at this point
Copy the full SHA db0e3d3View commit details
Commits on Jan 9, 2013
-
Support for multi-dimentional arrays in admin_config_set.php
This commit adds support for multi-dimentional arrays, as well as correct handling of commas and '=>' within strings. This is based on work by jspezeski; the original code was modified to align with MantisBT coding guidelines, simplification of the recursive function and fixing a couple of errors in regex. Fixes #13298
Configuration menu - View commit details
-
Copy full SHA for efb8b6b - Browse repository at this point
Copy the full SHA efb8b6bView commit details -
admin_config_set: Revised process_complex_value() function
The new code features an improved regex, which deals more efficiently with the parsing of multi-dimensional and associative arrays. Regex are defined as static variables for better performance with repeated and recursive calls Known issue: an invalid definition like 'array(array(1,2)=>array(3,4))' is not properly parsed. Fixes #13298
Configuration menu - View commit details
-
Copy full SHA for d000c4d - Browse repository at this point
Copy the full SHA d000c4dView commit details
Commits on Jan 22, 2013
-
Merge branch 'manage-config' into master-1.2.x
This branch implements several improvements to the Manage Configuration page, including: - better performance - filtering - ability to edit config options
Configuration menu - View commit details
-
Copy full SHA for e539dd6 - Browse repository at this point
Copy the full SHA e539dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6492038 - Browse repository at this point
Copy the full SHA 6492038View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for d38abf9 - Browse repository at this point
Copy the full SHA d38abf9View commit details
There are no files selected for viewing