Fix buggy Class#constants for Object (fixes #304)

adambeynon · adambeynon · commit 022a6bc89e7d · 2013-07-29T20:10:21.000+01:00
diff --git a/corelib/opal/class.rb b/corelib/opal/class.rb
@@ -177,7 +177,7 @@ def constants
       else {
         own_only = true;
         var parent = #{self}._super;
-        while (parent !== Opal.Object) {
+        while (parent && (parent !== Opal.Object)) {
           scopes.push(parent._scope);
           parent = parent._super;
         }
diff --git a/spec/opal/class/constants_spec.rb b/spec/opal/class/constants_spec.rb
@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe "Class#constants" do
+  it "does not break on Object" do
+    Object.constants.should be_kind_of(Array)
+  end
+end

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ def constants`
`177`	`177`	`else {`
`178`	`178`	`own_only = true;`
`179`	`179`	`var parent = #{self}._super;`
`180`		`- while (parent !== Opal.Object) {`
	`180`	`+ while (parent && (parent !== Opal.Object)) {`
`181`	`181`	`scopes.push(parent._scope);`
`182`	`182`	`parent = parent._super;`
`183`	`183`	`}`