Refactoring preconditions #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
escowles
commented
Apr 24, 2014
escowles
commented
- Checking date and etag separately, to provide appropriate error messages for clients
- Folding in cache control headers, so behavior is consistent
|
|
||
| if (builder != null) { | ||
| throw new WebApplicationException(builder.entity("ETag mismatch").build()); | ||
| Response.ResponseBuilder builder = request.evaluatePreconditions(roundedDate); |
There was a problem hiding this comment.
Something feels really funny about this, but I can't put my finger on it yet.
There was a problem hiding this comment.
I found the Jersey source code, and it checks the etag first:
I'll take a look at the spec to see if it says anything different, but otherwise I'll change the order of these checks to match the Jersey behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.