small optimizations

mojolicious · Oct 22, 2013 · 0725198 · 0725198
1 parent 81e12da
commit 0725198
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/Changes b/Changes
@@ -16,7 +16,7 @@
     Mojo::UserAgent::Proxy::is_needed.
   - Deprecated Mojo::UserAgent::name in favor of
     Mojo::UserAgent::Transactor::name.
-  - Added modules Mojo::UserAgent::Server and Mojo::UserAgent::Proxy.
+  - Added modules Mojo::UserAgent::Proxy and Mojo::UserAgent::Server.
   - Added proxy and server attributes to Mojo::UserAgent.
   - Removed deprecated attrs method from Mojo::DOM.
   - Improved Mojo::Message to allow max_message_size check to be disabled.

diff --git a/lib/Mojo/UserAgent/Server.pm b/lib/Mojo/UserAgent/Server.pm
@@ -19,27 +19,24 @@ sub app {
   return $self;
 }
 
-sub restart {
-  my $self = shift;
-  delete $self->{port};
-  $self->_restart;
-}
+sub restart { shift->_restart(1) }
 
 sub url {
   my $self = shift;
-  $self->_restart(@_)
+  $self->_restart(0, @_)
     if !$self->{server} || $self->{server}->ioloop ne $self->ioloop || @_;
   return Mojo::URL->new("$self->{proto}://localhost:$self->{port}/");
 }
 
 sub _restart {
-  my ($self, $proto) = @_;
+  my ($self, $full, $proto) = @_;
 
   my $server = $self->{server} = Mojo::Server::Daemon->new(
     app    => $self->app,
     ioloop => $self->ioloop,
     silent => 1
   );
+  delete $self->{port} if $full;
   die "Couldn't find a free TCP port for application.\n"
     unless my $port = $self->{port} ||= Mojo::IOLoop->generate_port;
   $self->{proto} = $proto ||= 'http';