TRUNK-3960 - Reload log4j.xml configuration without server restart #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without server restart
| <servlet> | ||
|
|
||
| <listener> | ||
| <listener-class>org.springframework.web.util.Log4jConfigListener</listener-class> |
There was a problem hiding this comment.
The javadoc says it should go before ContextLoaderListener, which is org.openmrs.web.Listener in OpenMRS. Please move it up.
ghost
assigned 
|
I have fixed the order for in which the listeners are being registered. |
|
I have tested this and noticed that the server still restarts!!! |
|
Merged with rebasing and a follow up fix in f3de4b6 |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.