Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: timvideos/gst-switch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1fce46ddae4a
Choose a base ref
...
head repository: timvideos/gst-switch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 92e171dcd815
Choose a head ref
  • 6 commits
  • 6 files changed
  • 2 contributors

Commits on Nov 9, 2014

  1. configure option to enable speakertrack/ptz

    Aayush Ahuja committed Nov 9, 2014
    Copy the full SHA
    9df7eb8 View commit details
  2. doing lint changes

    Aayush Ahuja committed Nov 9, 2014
    Copy the full SHA
    0d53bc4 View commit details
  3. fixing more lint errors

    Aayush Ahuja committed Nov 9, 2014
    Copy the full SHA
    79b963f View commit details
  4. fixing lint errors

    Aayush Ahuja committed Nov 9, 2014
    Copy the full SHA
    3ef5ccc View commit details
  5. fixing lint errors

    Aayush Ahuja committed Nov 9, 2014
    Copy the full SHA
    74df888 View commit details
  6. Merge pull request #33 from hyades/master

    configure option to enable speakertrack/ptz and lint changes
    mithro committed Nov 9, 2014
    Copy the full SHA
    92e171d View commit details
11 changes: 11 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
@@ -99,6 +99,17 @@ AC_ARG_ENABLE(gprof,
AM_CONDITIONAL(GCOV_ENABLED, test "x$BUILD_GCOV" = "xyes")
AM_CONDITIONAL(GPROF_ENABLED, test "x$BUILD_GPROF" = "xyes")

AC_ARG_ENABLE(speakertrack,
AS_HELP_STRING([--enable-speakertrack],[enable speakertrack]),
[
case "${enableval}" in
yes) BUILD_SPEAKERTRACK=yes ;;
no) BUILD_SPEAKERTRACK=no ;;
esac
],
[BUILD_SPEAKERTRACK=no])
AM_CONDITIONAL(SPEAKERTRACK_ENABLED, test "x$BUILD_SPEAKERTRACK" = "xyes")

dnl Check for the required version of GStreamer core (and gst-plugins-base)
dnl This will export GST_CFLAGS and GST_LIBS variables for use in Makefile.am
dnl
2 changes: 1 addition & 1 deletion python-api/gstswitch/controller.py
Original file line number Diff line number Diff line change
@@ -360,7 +360,7 @@ def parse_preview_ports(cls, res):
liststr = ast.literal_eval(res)
except (ValueError, SyntaxError):
raise ConnectionReturnError(("Connection returned "
"invalid values:{0}")
"invalid values:{0}")
.format(res))
preview_ports = []
for tupl in liststr:
6 changes: 1 addition & 5 deletions python-api/gstswitch/helpers.py
Original file line number Diff line number Diff line change
@@ -166,11 +166,7 @@ def terminate_video(self):
for _ in range(len(self._running_tests_video)):
self.terminate_index_video(0)

def new_test_audio(
self,
freq=110,
wave=None
):
def new_test_audio(self, freq=110, wave=None):
"""Start a new test audio
:param port: The port of where the TCP stream will be sent
Should be same as audio port of gst-switch-src
32 changes: 15 additions & 17 deletions python-api/tests/integrationtests/test_controller.py
Original file line number Diff line number Diff line change
@@ -386,7 +386,7 @@ def test_new_record(self):
sources.terminate_video()
serv.terminate(1)
assert ((os.path.exists(test_filename)) or
(os.path.exists(alt_test_filename))) is True
(os.path.exists(alt_test_filename))) is True
finally:
if serv.proc:
poll = serv.proc.poll()
@@ -405,14 +405,13 @@ class TestAdjustPIP(object):
NUM = 1
FACTOR = 1

def adjust_pip(
self,
xpos,
ypos,
width,
heigth,
index,
generate_frames=False):
def adjust_pip(self,
xpos,
ypos,
width,
heigth,
index,
generate_frames=False):
"""Create Controller object and call adjust_pip"""
for _ in range(self.NUM):
serv = Server(path=PATH)
@@ -531,14 +530,13 @@ class TestClickVideo(object):
NUM = 1
FACTOR = 1

def click_video(
self,
xpos,
ypos,
width,
heigth,
index,
generate_frames=False):
def click_video(self,
xpos,
ypos,
width,
heigth,
index,
generate_frames=False):
"""Create Controller object and call click_video method"""
for _ in range(self.NUM):
serv = Server(path=PATH)
21 changes: 8 additions & 13 deletions python-api/tests/unittests/test_helpers_unit.py
Original file line number Diff line number Diff line change
@@ -68,14 +68,13 @@ class MockVideoSrc(object):

"""A mock video source"""

def __init__(
self,
port,
width=300,
height=200,
pattern=None,
timeoverlay=False,
clockoverlay=False):
def __init__(self,
port,
width=300,
height=200,
pattern=None,
timeoverlay=False,
clockoverlay=False):
pass

def run(self):
@@ -154,11 +153,7 @@ class MockAudioSrc(object):

"""A Mock audio source"""

def __init__(
self,
port,
freq=110,
wave=None):
def __init__(self, port, freq=110, wave=None):
pass

def run(self):
6 changes: 5 additions & 1 deletion tools/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
bin_PROGRAMS = gst-switch-srv gst-switch-ui gst-switch-cap # gst-switch-ptz
if SPEAKERTRACK_ENABLED
bin_PROGRAMS = gst-switch-srv gst-switch-ui gst-switch-cap gst-switch-ptz
else
bin_PROGRAMS = gst-switch-srv gst-switch-ui gst-switch-cap
endif

if GCOV_ENABLED
# --coverage