reduce method calls

mojolicious · Jan 30, 2014 · 81c398b · 81c398b
1 parent a3ba3f3
commit 81c398b
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 17 deletions.
diff --git a/lib/Mojo/Date.pm b/lib/Mojo/Date.pm
@@ -11,14 +11,11 @@ my @MONTHS = qw(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec);
 my %MONTHS;
 @MONTHS{@MONTHS} = (0 .. 11);
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
 sub parse {
   my ($self, $date) = @_;
 
-  # Invalid
-  return $self unless defined $date;
-
   # epoch (784111777)
   return $self->epoch($date) if $date =~ /^\d+$/;
 

diff --git a/lib/Mojo/Home.pm b/lib/Mojo/Home.pm
@@ -60,12 +60,9 @@ sub list_files {
 
 sub mojo_lib_dir { catdir(dirname(__FILE__), '..') }
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
-sub parse {
-  my ($self, $path) = @_;
-  return defined $path ? $self->parts([splitdir $path]) : $self;
-}
+sub parse { shift->parts([splitdir shift]) }
 
 sub rel_dir { catdir(@{shift->parts}, split '/', shift) }
 sub rel_file { catfile(@{shift->parts}, split '/', shift) }

diff --git a/lib/Mojo/Parameters.pm b/lib/Mojo/Parameters.pm
@@ -44,7 +44,7 @@ sub merge {
   return $self;
 }
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
 sub param {
   my ($self, $name) = (shift, shift);
@@ -109,7 +109,7 @@ sub parse {
   if (@_ > 1) { $self->append(@_) }
 
   # String
-  else { $self->{string} = $_[0] }
+  else { $self->{string} = shift }
 
   return $self;
 }

diff --git a/lib/Mojo/Path.pm b/lib/Mojo/Path.pm
@@ -62,7 +62,7 @@ sub merge {
   return $self->trailing_slash($path->trailing_slash);
 }
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
 sub parse {
   my $self = shift;

diff --git a/lib/Mojo/URL.pm b/lib/Mojo/URL.pm
@@ -71,11 +71,10 @@ sub ihost {
 
 sub is_abs { !!shift->scheme }
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
 sub parse {
   my ($self, $url) = @_;
-  return $self unless $url;
 
   # Official regex from RFC 3986
   $url =~ m!^(([^:/?#]+):)?(//([^/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?!;

diff --git a/lib/Mojolicious/Routes/Pattern.pm b/lib/Mojolicious/Routes/Pattern.pm
@@ -45,7 +45,7 @@ sub match_partial {
   return $captures;
 }
 
-sub new { shift->SUPER::new->parse(@_) }
+sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }
 
 sub parse {
   my $self = shift;

diff --git a/lib/Mojolicious/Routes/Route.pm b/lib/Mojolicious/Routes/Route.pm
@@ -426,8 +426,8 @@ the current route.
   my $r = Mojolicious::Routes::Route->new;
   my $r = Mojolicious::Routes::Route->new('/:controller/:action');
 
-Construct a new L<Mojolicious::Routes::Route> object and <parse> pattern if
-necessary.
+Construct a new L<Mojolicious::Routes::Route> object and L</"parse"> pattern
+if necessary.
 
 =head2 options