Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 48b56a90722d
Choose a base ref
...
head repository: jruby/jruby
compare: 5ee82b6e30b9
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 5, 2014

  1. Move the logging of exceptions before the logging of backtraces 

    When -Xlog.backtraces=true and -Xlog.exceptions=true are used together the backtrace is logged before the exception, which is the opposite of what you would expect, and makes the output harder to understand.

This moves the logging of exceptions to before the code that triggers the logging of the backtraces.

This is not a fantastic solution, there’s nothing in this change that makes sure that the order stays this way, as soon as someone else does a refactoring of the code this will probably become inconsistent. However, I’ve followed the code to find out how the backtraces and exceptions are logged, and this change is the only one I could come up with that wouldn’t require a much more dangerous operation.
    @iconara
    iconara committed Nov 5, 2014
    Copy the full SHA
    8bb24ba View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2110 from iconara/log_exceptions_before_backtraces 

    Move the logging of exceptions before the logging of backtraces
    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    5ee82b6 View commit details
    Browse the repository at this point in the history