Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal-browser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e8dbf1307064
Choose a base ref
...
head repository: opal/opal-browser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3f69ad6a3ee9
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 27, 2014

  1. dom/event: document Target helpers as private

    @meh
    meh committed Jan 27, 2014
    Copy the full SHA
    cb7b132 View commit details

  2. dom/event/mouse: fix .construct in IE9

    @meh
    meh committed Jan 27, 2014
    Copy the full SHA
    786d0e6 View commit details

  3. spec: mark IE9 as passing

    @meh
    meh committed Jan 27, 2014
    Copy the full SHA
    3f69ad6 View commit details
Showing with 6 additions and 3 deletions.
  1. +0 −1 .travis.yml
  2. +3 −0 opal/browser/dom/event/base.rb
  3. +3 −2 opal/browser/dom/event/mouse.rb
1 change: 0 additions & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,6 @@ matrix:
# I know these fail
- env: SELENIUM_BROWSER=ie SELENIUM_VERSION=6
- env: SELENIUM_BROWSER=ie SELENIUM_VERSION=7
- env: SELENIUM_BROWSER=ie SELENIUM_VERSION=9

# ChromeDriver be broken
- env: SELENIUM_BROWSER=chrome SELENIUM_VERSION=31
3 changes: 3 additions & 0 deletions opal/browser/dom/event/base.rb
View file
Original file line number Diff line number Diff line change
@@ -23,14 +23,17 @@ def cancelable=(value)
end

module Target
# @private
def self.converters
@converters ||= []
end

# @private
def self.register(&block)
converters << block
end

# @private
def self.convert(value)
return value unless native?(value)

5 changes: 3 additions & 2 deletions opal/browser/dom/event/mouse.rb
View file
Original file line number Diff line number Diff line change
@@ -151,8 +151,9 @@ def self.construct(name, desc)
desc.view || window, desc.detail || 0,
desc.screenX || 0, desc.screenY || 0,
desc.clientX || 0, desc.clientY || 0,
desc.ctrlKey, desc.altKey, desc.shiftKey, desc.metaKey,
desc.button || 0, desc.relatedTarget);
desc.ctrlKey || false, desc.altKey || false,
desc.shiftKey || false, desc.metaKey || false,
desc.button || 0, desc.relatedTarget || null);
return event;
}