Fix #13816: Update history when copying issues

dregad · dregad · commit dd634e7c5f1e · 2012-03-01T22:58:00.000+01:00
Until now, copying bugs using the "View Issues" page creates wrong/
incomplete history (entries for notes reflect the id's of the original
issue's notes) and also does not record any trace that the new issue is
in fact clone of another, which can be a source of confusion.

This commit prevents the duplication of the original bug's history,
generating instead a single history entry similar to what happens when
cloning a bug with the Clone button in view.php page.

The display of history entries for cloned bugs has been slightly
modified, the bug id is now printed under the 'Field' column instead of
the 'Change' column, like entries for adding notes (as cloning s not a
change).
diff --git a/bug_actiongroup.php b/bug_actiongroup.php
@@ -112,7 +112,8 @@
 			$f_project_id = gpc_get_int( 'project_id' );
 
 			if ( access_has_project_level( config_get( 'report_bug_threshold' ), $f_project_id ) ) {
-				bug_copy( $t_bug_id, $f_project_id, true, true, true, true, true, true );
+				# Copy everything except history
+				bug_copy( $t_bug_id, $f_project_id, true, true, false, true, true, true );
 			} else {
 				$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_access' );
 			}
diff --git a/core/bug_api.php b/core/bug_api.php
@@ -892,6 +892,10 @@ function bug_check_workflow( $p_bug_status, $p_wanted_status ) {
  * @param int p_target_project_id
  * @param bool p_copy_custom_fields
  * @param bool p_copy_relationships
+ * @param bool p_copy_history
+ * @param bool p_copy_attachments
+ * @param bool p_copy_bugnotes
+ * @param bool p_copy_monitoring_users
  * @return int representing the new bugid
  * @access public
  */
@@ -1039,6 +1043,10 @@ function bug_copy( $p_bug_id, $p_target_project_id = null, $p_copy_custom_fields
 		}
 	}
 
+	# Create history entries to reflect the copy operation
+	history_log_event_special( $t_new_bug_id, BUG_CREATED_FROM, '', $t_bug_id );
+	history_log_event_special( $t_bug_id, BUG_CLONED_TO, '', $t_new_bug_id );
+
 	return $t_new_bug_id;
 }
 
diff --git a/core/history_api.php b/core/history_api.php
@@ -516,12 +516,10 @@ function history_localize_item( $p_field_name, $p_type, $p_old_value, $p_new_val
 					}
 					break;
 				case BUG_CLONED_TO:
-					$t_note = lang_get( 'bug_cloned_to' );
-					$t_change = bug_format_id( $p_new_value );
+					$t_note = lang_get( 'bug_cloned_to' ) . ': ' . bug_format_id( $p_new_value );
 					break;
 				case BUG_CREATED_FROM:
-					$t_note = lang_get( 'bug_created_from' );
-					$t_change = bug_format_id( $p_new_value );
+					$t_note = lang_get( 'bug_created_from' ) . ': ' . bug_format_id( $p_new_value );
 					break;
 				case CHECKIN:
 					$t_note = lang_get( 'checkin' );

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,8 @@`
`112`	`112`	`$f_project_id = gpc_get_int( 'project_id' );`
`113`	`113`
`114`	`114`	`if ( access_has_project_level( config_get( 'report_bug_threshold' ), $f_project_id ) ) {`
`115`		`- bug_copy( $t_bug_id, $f_project_id, true, true, true, true, true, true );`
	`115`	`+ # Copy everything except history`
	`116`	`+ bug_copy( $t_bug_id, $f_project_id, true, true, false, true, true, true );`
`116`	`117`	`} else {`
`117`	`118`	`$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_access' );`
`118`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -892,6 +892,10 @@ function bug_check_workflow( $p_bug_status, $p_wanted_status ) {`
`892`	`892`	`* @param int p_target_project_id`
`893`	`893`	`* @param bool p_copy_custom_fields`
`894`	`894`	`* @param bool p_copy_relationships`
	`895`	`+ * @param bool p_copy_history`
	`896`	`+ * @param bool p_copy_attachments`
	`897`	`+ * @param bool p_copy_bugnotes`
	`898`	`+ * @param bool p_copy_monitoring_users`
`895`	`899`	`* @return int representing the new bugid`
`896`	`900`	`* @access public`
`897`	`901`	`*/`
`@@ -1039,6 +1043,10 @@ function bug_copy( $p_bug_id, $p_target_project_id = null, $p_copy_custom_fields`
`1039`	`1043`	`}`
`1040`	`1044`	`}`
`1041`	`1045`
	`1046`	`+ # Create history entries to reflect the copy operation`
	`1047`	`+ history_log_event_special( $t_new_bug_id, BUG_CREATED_FROM, '', $t_bug_id );`
	`1048`	`+ history_log_event_special( $t_bug_id, BUG_CLONED_TO, '', $t_new_bug_id );`
	`1049`	`+`
`1042`	`1050`	`return $t_new_bug_id;`
`1043`	`1051`	`}`
`1044`	`1052`