Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 971aa36ea485
Choose a base ref
...
head repository: cdk/cdk
compare: 74ba3a4f701b
Choose a head ref
  • 9 commits
  • 11 files changed
  • 2 contributors

Commits on Dec 13, 2012

  1. Including the Mockito library in devellib. The library allows us to m… 

    …ock objects and create stub implementations in unit tests. The library is particularly useful in core where there is no access to data,silent or datadebug domain objects.
    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    a87dd75 View commit details
    Browse the repository at this point in the history

  2. Implemented a dynamic factory so we can replace the decision tree in … 

    …the ChemObjectBuilders. The dynamic factory uses reflection to inspect an implementations constructor. The factory also allows simple registration of an implementation with a given interface. As the factory uses a symbol table the factory can provide near constant time access (might have some hash collisions) for all class types. This implementation is advantageous to a decision tree (existing ChemObejctBuilders) as it is easier to register new classes and there is a negligible performance improvement. The factory also allows explict definition of object creation and post instantation modification (see. the javadoc).
    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    f9ede2a View commit details
    Browse the repository at this point in the history

  3. Added mockito to the Eclipse .classpath 

    Change-Id: Ifda0976c8c5e5cc7244cbc2016e0155dda4cca87
    @egonw
    egonw committed Dec 13, 2012
    Copy the full SHA
    61b7364 View commit details
    Browse the repository at this point in the history

  4. Implemented SilentChemObjectBuilder using the new DynamicFactory

    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    d14839b View commit details
    Browse the repository at this point in the history

  5. Included missing javadoc for DynamicFactory and SilentChemObjectBuilder

    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    5b97d06 View commit details
    Browse the repository at this point in the history

  6. Corrected bad practice in ConstructorKey.equals

    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    613d21c View commit details
    Browse the repository at this point in the history

  7. updated DefaultChemObject to use the new DynamicFactory

    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    4c0bcd1 View commit details
    Browse the repository at this point in the history

  8. Corrected typo in DynamicFactory javadoc and made the interfaces static

    @johnmay @egonw
    johnmay authored and egonw committed Dec 13, 2012
    Copy the full SHA
    b314703 View commit details
    Browse the repository at this point in the history

  9. s/implmentorsOf/implementorsOf/ 

    Change-Id: I5aaf8329ec9a52f06ded5912af05a5630e255898
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw
    egonw committed Dec 13, 2012
    Copy the full SHA
    74ba3a4 View commit details
    Browse the repository at this point in the history