Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit fafe09a

Browse files
committedFeb 28, 2012
Revert incorrect change to function definition
The parameters for function excel_format_custom_field() were unduly changed, preventing proper exporting of custom field data to Excel (custom fields would be displayed as '@@'). This is a regression from a39a948. Thanks to Roland Becker for catching this. This commit also fixes an incorrect comment in the function header for excel_format_plugin_column_value(). Affects #13728
1 parent ab0f381 commit fafe09a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎core/excel_api.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ function excel_format_additional_information( $p_bug ) {
457457
* @param $p_custom_field The custom field name (without 'custom_' prefix).
458458
* @returns The custom field value.
459459
*/
460-
function excel_format_custom_field( $p_bug ) {
460+
function excel_format_custom_field( $p_issue_id, $p_project_id, $p_custom_field ) {
461461
$t_field_id = custom_field_get_id_from_name( $p_custom_field );
462462

463463
if( $t_field_id === false ) {
@@ -477,7 +477,7 @@ function excel_format_custom_field( $p_bug ) {
477477
* Gets the formatted value for the specified plugin column value.
478478
* @param $p_custom_field The plugin column name.
479479
* @param $p_bug The bug to print the column for (needed for the display function of the plugin column).
480-
* @returns The custom field value.
480+
* @returns The plugin column value.
481481
*/
482482
function excel_format_plugin_column_value( $p_column, $p_bug ) {
483483
$t_plugin_columns = columns_get_plugin_columns();

0 commit comments

Comments
 (0)
Please sign in to comment.