Skip to content

Commit

Permalink
Item13117: CHECK is no longer an array.
Browse files Browse the repository at this point in the history
SMELL:  I thought the "also" setting was supposed to trigger a 2nd
checker.   If A changes, also check B.   However the one place this is
used - AuthScripts,  doesn't seem to behave that way.   Changing the
LoginManager setting doesn't trigger the AuthScripts checker.
  • Loading branch information
gac410 committed Jan 14, 2015
1 parent 8edbfc5 commit 1fbf9c9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/lib/Foswiki/Configure/Value.pm
Expand Up @@ -476,13 +476,13 @@ sub find_also_dependencies {
foreach my $slave ( split( /[\s,]+/, $this->{CHECK_ON_CHANGE} ) ) {
my $vob = $root->getValueObject($slave);
next unless ($vob);
my $check = $vob->{CHECK}->[0];
my $check = $vob->{CHECK};
if ($check) {
$check->{also} ||= [];
push( @{ $check->{also} }, $slave );
}
else {
$vob->{CHECK}->[0] = { also => [$slave] };
$vob->{CHECK} = { also => [$slave] };
}
}
}
Expand Down

0 comments on commit 1fbf9c9

Please sign in to comment.