Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring display controller #531

Closed
wants to merge 19 commits into from
Closed

Refactoring display controller #531

wants to merge 19 commits into from

Conversation

eurich
Copy link
Member

@eurich eurich commented Jun 15, 2013

here we go again :)

  • moved db queries and functions to related subs.
  • methods visibility
  • fixed some bugs due to not initialized vars..

eurich and others added 19 commits June 15, 2013 13:33
@eurich
methods visibility
eb4b5d9 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
db query to subs
abdb43f 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
again, db query to subs
1038aa9 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
another db query to subs
2b2f69b 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
db query to subs
92a6258 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
moved prepareDisplayContext() to subs.
232c17f 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
ups, comment mistakenly added to wrong function.
6e4fccd 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
moved attachments related functions to subs.
4166613 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
removed outdated $db and global.
e928172 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
moved db query to subs.
ddbad61 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
fixed undefined var bug.
cdffe27 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
missing globals.
5023f19 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
missing global
b2ba566 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
$save_errors was never used anywhere else -> removed
fb575fd 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
ups
3198adc 
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@norv
Refactor the prepareDisplayContext callback as a callback method.
04ff4c0 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Refactor previous currentMessage() into currentContext() and reuse it
c597cfa 
for Search controller.
Quick-wrap Search controller as a class and set up a similar callback method
for prepareSearchContext_callback().

Signed-off-by: Norv <a.w.norv@gmail.com>
@eurich
Merge pull request #5 from norv/te_refactoring_display
ec5b379 
Refactoring display
@eurich
Merge branch 'master' of https://github.com/elkarte/Elkarte into refa…
6af5544 
…ctoring_display

Signed-off-by: Thorsten Eurich <thorsten@eurich.de>

Conflicts:
	sources/Dispatcher.class.php
	sources/controllers/Search.controller.php
@norv norv mentioned this pull request Jun 19, 2013
Merged
@norv
Copy link
Contributor

norv commented Jun 19, 2013

I'm merging the revised version (I think this work should be in asap!). I hope I didn't miss anything, only added a few things to it. /looks around.

@norv norv closed this Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eurich @norv