Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC64 support in configure file #3195

Closed
wants to merge 2 commits into from
Closed

PowerPC64 support in configure file #3195

wants to merge 2 commits into from

Conversation

gustavotemple
Copy link
Contributor

This change defines the method detect_ppc64. If the architecture is
PowerPC64, only the LLVM equal to or greater than 3.5 have support,
so, the method detects error in this situation.

@yorickpeterse
Copy link
Contributor

The LLVM requirement isn't strictly needed. Since we'll be moving to mcjit in the near future we'll need to require LLVM 3.5/3.6 anyway, unless we intend to use some setup that is compatible with older LLVM versions.

Second, the indentation in the commits seems to be off. Make sure you're using 2 spaces (not tabs) per indentation level for Ruby source code.

@gustavotemple
Copy link
Contributor Author

@yorickpeterse, thank you for the explanation, in this case, I think this PR is useless, can I close it?

@yorickpeterse
Copy link
Contributor

@gustavotemple No, lets keep it open. Just for the sake of it I'd like to have @brixen's opinion on this as well.

This change defines the method detect_ppc64. If the architecture is
PowerPC64, only the LLVM equal to or greater than 3.5 have support,
so, the method detects error in this situation.
@brixen
Copy link
Member

brixen commented Nov 26, 2014

@gustavotemple if the only reason for @ppc64 is to restrict the LLVM version, then please close this. As @yorickpeterse said, we'll be moving to the new JIT API and we can simply specify LLVM 3.5+ at that point.

@gustavotemple
Copy link
Contributor Author

@brixen: done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants